From 8eb50a8917189cb196e9fb99c00507d05e77c463 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E9=9B=B7=E5=AE=B6=E5=85=B4?= <leij49456@gmail.com>
Date: Wed, 29 Oct 2025 13:57:16 +0800
Subject: [PATCH] fix: correctly resume from suspend by waiting pipewire resume
 (#2320)

---
 dots/.config/quickshell/ii/services/Audio.qml | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/dots/.config/quickshell/ii/services/Audio.qml b/dots/.config/quickshell/ii/services/Audio.qml
index 4ce6521c6..9bb096208 100644
--- a/dots/.config/quickshell/ii/services/Audio.qml
+++ b/dots/.config/quickshell/ii/services/Audio.qml
@@ -29,12 +29,18 @@ Singleton {
         property real lastVolume: 0
         function onVolumeChanged() {
             if (!Config.options.audio.protection.enable) return;
+            const newVolume = sink.audio.volume;
+            // when resuming from suspend, we should not write volume to avoid pipewire volume reset issues
+            if (isNaN(newVolume) || newVolume === undefined || newVolume === null) {
+                lastReady = false;
+                lastVolume = 0;
+                return;
+            }
             if (!lastReady) {
-                lastVolume = sink.audio.volume;
+                lastVolume = newVolume;
                 lastReady = true;
                 return;
             }
-            const newVolume = sink.audio.volume;
             const maxAllowedIncrease = Config.options.audio.protection.maxAllowedIncrease / 100; 
             const maxAllowed = Config.options.audio.protection.maxAllowed / 100;
 
@@ -45,9 +51,6 @@ Singleton {
                 root.sinkProtectionTriggered(Translation.tr("Exceeded max allowed"));
                 sink.audio.volume = Math.min(lastVolume, maxAllowed);
             }
-            if (sink.ready && (isNaN(sink.audio.volume) || sink.audio.volume === undefined || sink.audio.volume === null)) {
-                sink.audio.volume = 0;
-            }
             lastVolume = sink.audio.volume;
         }
     }