From 90c3b642b2d22a678b6aef34d3173e368d2afc0e Mon Sep 17 00:00:00 2001
From: end-4 <97237370+end-4@users.noreply.github.com>
Date: Sun, 15 Mar 2026 17:00:25 +0100
Subject: [PATCH] hefty: bar: make popups not move while open

---
 .../bar/HBarWidgetShapeBackground.qml         | 22 ++++++++++++++++++-
 1 file changed, 21 insertions(+), 1 deletion(-)

diff --git a/dots/.config/quickshell/ii/modules/hefty/topLayer/bar/HBarWidgetShapeBackground.qml b/dots/.config/quickshell/ii/modules/hefty/topLayer/bar/HBarWidgetShapeBackground.qml
index 52ef16406..0d7b8622a 100644
--- a/dots/.config/quickshell/ii/modules/hefty/topLayer/bar/HBarWidgetShapeBackground.qml
+++ b/dots/.config/quickshell/ii/modules/hefty/topLayer/bar/HBarWidgetShapeBackground.qml
@@ -65,14 +65,23 @@ Shapes.ShapeCanvas {
         const maxOffset = maxPopupY - yInGlobal;
         return maxOffset;
     }
+    property bool lockPopupX: false
+    property bool lockPopupY: false
     readonly property real popupXOffset: {
+        // print("popupXOffset", popupXOffset, "lock", lockPopupX)
+        if (bgShape.lockPopupX) return;
+        // if (bgShape.showPopup) lockPopupX = true;
         if (!vertical) return Math.min(Math.max(-(popupWidth - containerShape.width) / 2, minPopupXOffset), maxPopupXOffset);
         else return atBottom ? -(popupShape.width + spacing) : (containerShape.width + spacing);
     }
+    onPopupXOffsetChanged: if (bgShape.showPopup) lockPopupX = true;
     readonly property real popupYOffset: {
+        if (bgShape.lockPopupY) return;
+        // if (bgShape.showPopup) lockPopupY = true;
         if (!vertical) return atBottom ? -(popupShape.height + spacing) : (containerShape.height + spacing);
         else return Math.min(Math.max(-(popupHeight - containerShape.height) / 2, minPopupYOffset), maxPopupYOffset)
     }
+    onPopupYOffsetChanged: if (bgShape.showPopup) lockPopupY = true;
 
     // Positioning
     readonly property real popupContentOffsetBase: -baseMargin + popupPadding
@@ -111,7 +120,18 @@ Shapes.ShapeCanvas {
     }
     property bool popupHiding: false
     onShowPopupChanged: popupHiding = true
-    onProgressChanged: if (progress == 1) popupHiding = false
+    onProgressChanged: {
+        if (progress == 1) {
+            popupHiding = false
+            if (showPopup) {
+                lockPopupX = true;
+                lockPopupY = true;
+            } else {
+                lockPopupX = false;
+                lockPopupY = false;
+            }
+        }
+    }
     color: showPopup || popupHiding ? C.Appearance.colors.colLayer3Base : C.Appearance.colors.colLayer1
     xOffset: {
         if (!vertical) return showPopup ? Math.max(-popupXOffset, 0) : 0;