From c1a5641ff5cf2b7b82590aa5474805f8329e9e9e Mon Sep 17 00:00:00 2001 From: end-4 <97237370+end-4@users.noreply.github.com> Date: Mon, 27 Oct 2025 17:32:26 +0100 Subject: [PATCH] fix wrong minimum brightness (#2310) --- dots/.config/quickshell/ii/services/Brightness.qml | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/dots/.config/quickshell/ii/services/Brightness.qml b/dots/.config/quickshell/ii/services/Brightness.qml index e2d164814..5232f76f9 100644 --- a/dots/.config/quickshell/ii/services/Brightness.qml +++ b/dots/.config/quickshell/ii/services/Brightness.qml @@ -16,8 +16,6 @@ import QtQuick */ Singleton { id: root - property real minimumBrightnessAllowed: 0.00001 // Setting to 0 would kind of turn off the screen. We don't want that. - signal brightnessChanged() property var ddcMonitors: [] @@ -137,14 +135,14 @@ Singleton { } function syncBrightness() { - const brightnessValue = Math.max(monitor.multipliedBrightness, root.minimumBrightnessAllowed) - const rounded = Math.round(brightnessValue * monitor.rawMaxBrightness); - setProc.command = isDdc ? ["ddcutil", "-b", busNum, "setvcp", "10", rounded] : ["brightnessctl", "--class", "backlight", "s", rounded, "--quiet"]; + const brightnessValue = Math.max(monitor.multipliedBrightness, 0) + const rawValueRounded = Math.max(Math.floor(brightnessValue * monitor.rawMaxBrightness), 1); + setProc.command = isDdc ? ["ddcutil", "-b", busNum, "setvcp", "10", rawValueRounded] : ["brightnessctl", "--class", "backlight", "s", rawValueRounded, "--quiet"]; setProc.startDetached(); } function setBrightness(value: real): void { - value = Math.max(root.minimumBrightnessAllowed, Math.min(1, value)); + value = Math.max(0, Math.min(1, value)); monitor.brightness = value; }