From 51310e632c7e89f5da68cea1b7dcecf1a6bf3c52 Mon Sep 17 00:00:00 2001
From: end-4 <97237370+end-4@users.noreply.github.com>
Date: Sat, 16 Aug 2025 14:47:01 +0700
Subject: [PATCH] fix media controls positioning for vertical bar

---
 .../modules/mediaControls/MediaControls.qml   | 21 ++++++++++++-------
 .../modules/mediaControls/PlayerControl.qml   |  3 ---
 2 files changed, 13 insertions(+), 11 deletions(-)

diff --git a/.config/quickshell/ii/modules/mediaControls/MediaControls.qml b/.config/quickshell/ii/modules/mediaControls/MediaControls.qml
index 2774e8099..41347d5ce 100644
--- a/.config/quickshell/ii/modules/mediaControls/MediaControls.qml
+++ b/.config/quickshell/ii/modules/mediaControls/MediaControls.qml
@@ -111,21 +111,24 @@ Scope {
 
             exclusionMode: ExclusionMode.Ignore
             exclusiveZone: 0
-            margins {
-                top: Appearance.sizes.barHeight
-                bottom: Appearance.sizes.barHeight
-                left: (mediaControlsRoot.screen.width / 2) - (osdWidth / 2) - widgetWidth
-            }
             implicitWidth: root.widgetWidth
             implicitHeight: playerColumnLayout.implicitHeight
             color: "transparent"
             WlrLayershell.namespace: "quickshell:mediaControls"
 
             anchors {
-                top: !Config.options.bar.bottom
-                bottom: Config.options.bar.bottom
-                left: true
+                top: !Config.options.bar.bottom || Config.options.bar.vertical
+                bottom: Config.options.bar.bottom && !Config.options.bar.vertical
+                left: !(Config.options.bar.vertical && Config.options.bar.bottom)
+                right: Config.options.bar.vertical && Config.options.bar.bottom
             }
+            margins {
+                top: Config.options.bar.vertical ? ((mediaControlsRoot.screen.height / 2) - widgetHeight * 1.5) : Appearance.sizes.barHeight
+                bottom: Appearance.sizes.barHeight
+                left: Config.options.bar.vertical ? Appearance.sizes.barHeight : ((mediaControlsRoot.screen.width / 2) - (osdWidth / 2) - widgetWidth)
+                right: Appearance.sizes.barHeight
+            }
+
             mask: Region {
                 item: playerColumnLayout
             }
@@ -143,6 +146,8 @@ Scope {
                         required property MprisPlayer modelData
                         player: modelData
                         visualizerPoints: root.visualizerPoints
+                        implicitWidth: widgetWidth
+                        implicitHeight: widgetHeight
                     }
                 }
             }
diff --git a/.config/quickshell/ii/modules/mediaControls/PlayerControl.qml b/.config/quickshell/ii/modules/mediaControls/PlayerControl.qml
index 6f63c8369..673ad289f 100644
--- a/.config/quickshell/ii/modules/mediaControls/PlayerControl.qml
+++ b/.config/quickshell/ii/modules/mediaControls/PlayerControl.qml
@@ -23,9 +23,6 @@ Item { // Player instance
     property real maxVisualizerValue: 1000 // Max value in the data points
     property int visualizerSmoothing: 2 // Number of points to average for smoothing
 
-    implicitWidth: widgetWidth
-    implicitHeight: widgetHeight
-
     component TrackChangeButton: RippleButton {
         implicitWidth: 24
         implicitHeight: 24