kenji/illogical-impulse
1
0
Fork 0
forked from Shinonome/dots-hyprland
Code Pull Requests Activity

ags: remove timeout source after notification dismissed

Browse Source 
This fixes the following log spam:

(com.github.Aylur.ags:2273075): Gjs-CRITICAL **: 11:15:29.279: Object .Ags_Label (0x5f2be6736120), has been already disposed — impossible to get any property from it. This might be caused by the object having been destroyed from C code using something such as destroy(), dispose(), or remove() vfuncs.
== Stack trace for context 0x5f2be48b33d0 ==
#0   7ffcd01459e0 b   resource:///com/github/Aylur/ags/widgets/label.js:39 (1dcdaf08bb00 @ 10)
#1   5f2be497b5e0 i   file:///home/foobar/.config/ags/modules/.commonwidgets/notification.js:253 (1dcdaf0b72e0 @ 10)
#2   5f2be497b560 i   resource:///com/github/Aylur/ags/utils/timeout.js:14 (1f5daab1150 @ 6)
#3   5f2be497b498 i   resource:///org/gnome/gjs/modules/core/overrides/GLib.js:266 (1f5daa7d560 @ 139)

(com.github.Aylur.ags:2273075): Gjs-CRITICAL **: 11:15:29.279: Object .Ags_Label (0x5f2be6736120), has been already disposed — impossible to set any property on it. This might be caused by the object having been destroyed from C code using something such as destroy(), dispose(), or remove() vfuncs.
== Stack trace for context 0x5f2be48b33d0 ==
#0   7ffcd01459e0 b   resource:///com/github/Aylur/ags/widgets/label.js:51 (1dcdaf08bb00 @ 190)
#1   5f2be497b5e0 i   file:///home/foobar/.config/ags/modules/.commonwidgets/notification.js:253 (1dcdaf0b72e0 @ 10)
#2   5f2be497b560 i   resource:///com/github/Aylur/ags/utils/timeout.js:14 (1f5daab1150 @ 6)
#3   5f2be497b498 i   resource:///org/gnome/gjs/modules/core/overrides/GLib.js:266 (1f5daa7d560 @ 139)
This commit is contained in:
Moeta Yuko
2024-08-01 11:45:56 +08:00
parent 364c482d3e
commit 560d107baf
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.config/ags/modules/.commonwidgets/notification.js
+6 -2
View File
@@ -250,8 +250,12 @@ export default ({
className: 'txt-smaller txt-semibold', className: 'txt-smaller txt-semibold',
label: initTimeString, label: initTimeString,
setup: initTimeString == 'Now' ? (self) => { setup: initTimeString == 'Now' ? (self) => {
Utils.timeout(60000, () => self.label = getFriendlyNotifTimeString(notifObject.time)) let id = Utils.timeout(60000, () => {
} : () => {}, self.label = getFriendlyNotifTimeString(notifObject.time);
id = null;
});
self.connect('destroy', () => { if (id) GLib.source_remove(id) });
} : () => { },
}); });
const notifText = Box({ const notifText = Box({
valign: Gtk.Align.CENTER, valign: Gtk.Align.CENTER,