kenji/illogical-impulse
1
0
Fork 0
forked from Shinonome/dots-hyprland
Code Pull Requests Activity

fix(brightness): use the monitor's max brightness instead of '100' (#1966)

Browse Source
This commit is contained in:
end-4
2025-09-11 23:28:29 +02:00
committed by GitHub
parent 7f1b67d21c d9688884e4
commit d37cf9e9c4
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.config/quickshell/ii/services/Brightness.qml
+6 -4
View File
@@ -76,6 +76,7 @@ Singleton {
required property ShellScreen screen required property ShellScreen screen
readonly property bool isDdc: root.ddcMonitors.some(m => m.model === screen.model) readonly property bool isDdc: root.ddcMonitors.some(m => m.model === screen.model)
readonly property string busNum: root.ddcMonitors.find(m => m.model === screen.model)?.busNum ?? "" readonly property string busNum: root.ddcMonitors.find(m => m.model === screen.model)?.busNum ?? ""
property int rawMaxBrightness: 100
property real brightness property real brightness
property bool ready: false property bool ready: false
@@ -95,7 +96,8 @@ Singleton {
stdout: SplitParser { stdout: SplitParser {
onRead: data => { onRead: data => {
const [, , , current, max] = data.split(" "); const [, , , current, max] = data.split(" ");
monitor.brightness = parseInt(current) / parseInt(max); monitor.rawMaxBrightness = parseInt(max);
monitor.brightness = parseInt(current) / monitor.rawMaxBrightness;
monitor.ready = true; monitor.ready = true;
} }
} }
@@ -103,11 +105,11 @@ Singleton {
function setBrightness(value: real): void { function setBrightness(value: real): void {
value = Math.max(0.01, Math.min(1, value)); value = Math.max(0.01, Math.min(1, value));
const rounded = Math.round(value * 100); const rounded = Math.round(value * monitor.rawMaxBrightness);
if (Math.round(brightness * 100) === rounded) if (Math.round(brightness * monitor.rawMaxBrightness) === rounded)
return; return;
brightness = value; brightness = value;
setProc.command = isDdc ? ["ddcutil", "-b", busNum, "setvcp", "10", rounded] : ["brightnessctl", "s", `${rounded}%`, "--quiet"]; setProc.command = isDdc ? ["ddcutil", "-b", busNum, "setvcp", "10", rounded] : ["brightnessctl", "s", rounded, "--quiet"];
setProc.startDetached(); setProc.startDetached();
} }